cgen: allow unwrapping of x as string expr
#22953
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ath { sin, cos }`"
This reverts commit ddf0468.
felipensp
reviewed
Nov 24, 2024
| @@ -145,3 +145,27 @@ fn (mut g Gen) dot_or_ptr(val_type ast.Type) string { | |||
| '.' | |||
| } | |||
| } | |||
|
|
|||
| @[inline] | |||
There was a problem hiding this comment.
I think it is too long for @[inline]
felipensp
reviewed
Nov 24, 2024
| @@ -7801,7 +7782,17 @@ fn (mut g Gen) as_cast(node ast.AsCast) { | |||
| g.as_cast_type_names[idx] = variant_sym.name | |||
| } | |||
| } else { | |||
| g.expr(node.expr) | |||
| if node.expr is ast.Ident { | |||
| if node.expr.info is ast.IdentVar { | |||
There was a problem hiding this comment.
What happens if it is not a IdentVar?
There was a problem hiding this comment.
Not sure if ast.IdentFn needs to unwrap the option type as this already works
fn get_opt_fn(a int) ?fn(int) int {
if a < 0 {
return none
}
return fn (n int) int {
return n + n
}
}
fn main() {
d := get_opt_fn(12)
dump(d as fn(int) int)
e := d as fn(int) int
dump(e(12))
}though dump((d as fn(int) int)(12)) doesn't work due to the parser error. I don't think this would be valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22947
Huly®: V_0.6-21395